net: stmmac: qcom-ethqos: remove of_get_phy_mode()
authorRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Wed, 12 Mar 2025 09:20:26 +0000 (09:20 +0000)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 18 Mar 2025 14:53:15 +0000 (15:53 +0100)
devm_stmmac_probe_config_dt() already gets the PHY mode from firmware,
which is stored in plat_dat->phy_interface. Therefore, we don't need to
get it a second time in qcom_ethqos_probe(). Use
plat_dat->phy_interface to initialise ethqos->phy_mode.

Reviewed-by: Michal Kubiak <michal.kubiak@intel.com>
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Link: https://patch.msgid.link/E1tsIGI-005uzT-KB@rmk-PC.armlinux.org.uk
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c

index eafe637540b606d5bd346c6218d2b3e469e55fbb..0e4da216f942c6ccb00455c0ef513d4462144efd 100644 (file)
@@ -794,9 +794,7 @@ static int qcom_ethqos_probe(struct platform_device *pdev)
        if (!ethqos)
                return -ENOMEM;
 
-       ret = of_get_phy_mode(np, &ethqos->phy_mode);
-       if (ret)
-               return dev_err_probe(dev, ret, "Failed to get phy mode\n");
+       ethqos->phy_mode = plat_dat->phy_interface;
        switch (ethqos->phy_mode) {
        case PHY_INTERFACE_MODE_RGMII:
        case PHY_INTERFACE_MODE_RGMII_ID: