pds_core: Remove redundant null pointer checks

Since the debugfs_create_dir() never returns a null pointer, checking
the return value for a null pointer is redundant, and using IS_ERR is
safe enough.

Signed-off-by: Li Zetao <lizetao1@huawei.com>
Link: https://patch.msgid.link/20240903143343.2004652-1-lizetao1@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/drivers/net/ethernet/amd/pds_core/debugfs.c b/drivers/net/ethernet/amd/pds_core/debugfs.c
index 6bdd02b7aa6de287851432aefdf78bfe36d3da1b..ac37a4e738ae7d4669f052cc3785bae5715fdf23 100644 (file)
--- a/drivers/net/ethernet/amd/pds_core/debugfs.c
+++ b/drivers/net/ethernet/amd/pds_core/debugfs.c
@@ -112,7 +112,7 @@ void pdsc_debugfs_add_qcq(struct pdsc *pdsc, struct pdsc_qcq *qcq)
        struct pdsc_cq *cq = &qcq->cq;
 
        qcq_dentry = debugfs_create_dir(q->name, pdsc->dentry);
-       if (IS_ERR_OR_NULL(qcq_dentry))
+       if (IS_ERR(qcq_dentry))
                return;
        qcq->dentry = qcq_dentry;
 
@@ -123,7 +123,7 @@ void pdsc_debugfs_add_qcq(struct pdsc *pdsc, struct pdsc_qcq *qcq)
        debugfs_create_x32("accum_work", 0400, qcq_dentry, &qcq->accum_work);
 
        q_dentry = debugfs_create_dir("q", qcq->dentry);
-       if (IS_ERR_OR_NULL(q_dentry))
+       if (IS_ERR(q_dentry))
                return;
 
        debugfs_create_u32("index", 0400, q_dentry, &q->index);
@@ -135,7 +135,7 @@ void pdsc_debugfs_add_qcq(struct pdsc *pdsc, struct pdsc_qcq *qcq)
        debugfs_create_u16("head", 0400, q_dentry, &q->head_idx);
 
        cq_dentry = debugfs_create_dir("cq", qcq->dentry);
-       if (IS_ERR_OR_NULL(cq_dentry))
+       if (IS_ERR(cq_dentry))
                return;
 
        debugfs_create_x64("base_pa", 0400, cq_dentry, &cq->base_pa);
@@ -148,7 +148,7 @@ void pdsc_debugfs_add_qcq(struct pdsc *pdsc, struct pdsc_qcq *qcq)
                struct pdsc_intr_info *intr = &pdsc->intr_info[qcq->intx];
 
                intr_dentry = debugfs_create_dir("intr", qcq->dentry);
-               if (IS_ERR_OR_NULL(intr_dentry))
+               if (IS_ERR(intr_dentry))
                        return;
 
                debugfs_create_u32("index", 0400, intr_dentry, &intr->index);