watchdog: exar: Shorten identity name to fit correctly
authorKees Cook <kees@kernel.org>
Tue, 15 Apr 2025 22:52:49 +0000 (15:52 -0700)
committerKees Cook <kees@kernel.org>
Mon, 28 Apr 2025 17:32:43 +0000 (10:32 -0700)
The static initializer for struct watchdog_info::identity is too long
and gets initialized without a trailing NUL byte. Since the length
of "identity" is part of UAPI and tied to ioctls, just shorten
the name of the device. Avoids the warning seen with GCC 15's
-Wunterminated-string-initialization option:

drivers/watchdog/exar_wdt.c:224:27: warning: initializer-string for array of 'unsigned char' truncates NUL terminator but destination lacks 'nonstring' attribute (33 chars into 32 available) [-Wunterminated-string-initialization]
  224 |         .identity       = "Exar/MaxLinear XR28V38x Watchdog",
      |                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Fixes: 81126222bd3a ("watchdog: Exar/MaxLinear XR28V38x driver")
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20250415225246.work.458-kees@kernel.org
Signed-off-by: Kees Cook <kees@kernel.org>
drivers/watchdog/exar_wdt.c

index 7c61ff3432711623aa4f6992f41c94f2664a5372..c2e3bb08df899abdd354ada658d89a033ae7d88e 100644 (file)
@@ -221,7 +221,7 @@ static const struct watchdog_info exar_wdt_info = {
        .options        = WDIOF_KEEPALIVEPING |
                          WDIOF_SETTIMEOUT |
                          WDIOF_MAGICCLOSE,
-       .identity       = "Exar/MaxLinear XR28V38x Watchdog",
+       .identity       = "Exar XR28V38x Watchdog",
 };
 
 static const struct watchdog_ops exar_wdt_ops = {