tpm_crb_ffa: use dev_xx() macro to print log
authorYeoreum Yun <yeoreum.yun@arm.com>
Tue, 15 Apr 2025 18:50:13 +0000 (19:50 +0100)
committerJarkko Sakkinen <jarkko@kernel.org>
Fri, 23 May 2025 16:05:51 +0000 (19:05 +0300)
Instead of pr_xxx() macro, use dev_xxx() to print log.
This patch changes some error log level to warn log level when
the tpm_crb_ffa secure partition doesn't support properly but
system can run without it.
(i.e) unsupport of direct message ABI or unsupported ABI version

Signed-off-by: Yeoreum Yun <yeoreum.yun@arm.com>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
drivers/char/tpm/tpm_crb_ffa.c

index fed775cf53ab92a84d1fbdb77839b3a1291ce812..66b38b2cbdd50eb838322ba61a059ea7c44fccb9 100644 (file)
@@ -303,7 +303,7 @@ static int tpm_crb_ffa_probe(struct ffa_device *ffa_dev)
 
        if (!ffa_partition_supports_direct_recv(ffa_dev) &&
            !ffa_partition_supports_direct_req2_recv(ffa_dev)) {
-               pr_err("TPM partition doesn't support direct message receive.\n");
+               dev_warn(&ffa_dev->dev, "partition doesn't support direct message receive.\n");
                return -EINVAL;
        }
 
@@ -324,17 +324,17 @@ static int tpm_crb_ffa_probe(struct ffa_device *ffa_dev)
        rc = tpm_crb_ffa_get_interface_version(&tpm_crb_ffa->major_version,
                                               &tpm_crb_ffa->minor_version);
        if (rc) {
-               pr_err("failed to get crb interface version. rc:%d", rc);
+               dev_err(&ffa_dev->dev, "failed to get crb interface version. rc:%d\n", rc);
                goto out;
        }
 
-       pr_info("ABI version %u.%u", tpm_crb_ffa->major_version,
+       dev_info(&ffa_dev->dev, "ABI version %u.%u\n", tpm_crb_ffa->major_version,
                tpm_crb_ffa->minor_version);
 
        if (tpm_crb_ffa->major_version != CRB_FFA_VERSION_MAJOR ||
            (tpm_crb_ffa->minor_version > 0 &&
            tpm_crb_ffa->minor_version < CRB_FFA_VERSION_MINOR)) {
-               pr_err("Incompatible ABI version");
+               dev_warn(&ffa_dev->dev, "Incompatible ABI version\n");
                goto out;
        }