drm/i915/display/global_state: Prefer drm_WARN* over WARN*
authorPankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com>
Mon, 6 Apr 2020 11:27:51 +0000 (16:57 +0530)
committerJani Nikula <jani.nikula@intel.com>
Tue, 21 Apr 2020 07:54:28 +0000 (10:54 +0300)
struct drm_device specific drm_WARN* macros include device information
in the backtrace, so we know what device the warnings originate from.

Prefer drm_WARN* over WARN* calls.

Signed-off-by: Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200406112800.23762-10-pankaj.laxminarayan.bharadiya@intel.com
drivers/gpu/drm/i915/display/intel_global_state.c

index 6f72feb14f3e2c99ce5ba69998b2ee4318cbe688..212d4ee682059e7dec696cd8cecb7c8ddbad2698 100644 (file)
@@ -64,7 +64,7 @@ static void assert_global_state_read_locked(struct intel_atomic_state *state)
                        return;
        }
 
-       WARN(1, "Global state not read locked\n");
+       drm_WARN(&dev_priv->drm, 1, "Global state not read locked\n");
 }
 
 struct intel_global_state *
@@ -148,7 +148,7 @@ void intel_atomic_swap_global_state(struct intel_atomic_state *state)
 
        for_each_oldnew_global_obj_in_state(state, obj, old_obj_state,
                                            new_obj_state, i) {
-               WARN_ON(obj->state != old_obj_state);
+               drm_WARN_ON(&dev_priv->drm, obj->state != old_obj_state);
 
                /*
                 * If the new state wasn't modified (and properly