net: page_pool: don't cast mp param to devmem
authorPavel Begunkov <asml.silence@gmail.com>
Tue, 4 Feb 2025 21:56:12 +0000 (13:56 -0800)
committerJakub Kicinski <kuba@kernel.org>
Fri, 7 Feb 2025 00:27:30 +0000 (16:27 -0800)
page_pool_check_memory_provider() is a generic path and shouldn't assume
anything about the actual type of the memory provider argument. It's
fine while devmem is the only provider, but cast away the devmem
specific binding types to avoid confusion.

Reviewed-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Mina Almasry <almasrymina@google.com>
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Signed-off-by: David Wei <dw@davidwei.uk>
Link: https://patch.msgid.link/20250204215622.695511-2-dw@davidwei.uk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/core/page_pool_user.c

index 6677e0c2e2565073383dea6970c81f52b6bf9de0..d5e214c30c310f9164a27b140a61d7dc067b35d5 100644 (file)
@@ -356,7 +356,7 @@ void page_pool_unlist(struct page_pool *pool)
 int page_pool_check_memory_provider(struct net_device *dev,
                                    struct netdev_rx_queue *rxq)
 {
-       struct net_devmem_dmabuf_binding *binding = rxq->mp_params.mp_priv;
+       void *binding = rxq->mp_params.mp_priv;
        struct page_pool *pool;
        struct hlist_node *n;