drm/amdgpu: Fix return type in 'aca_bank_hwip_is_matched()'
authorSrinivasan Shanmugam <srinivasan.shanmugam@amd.com>
Tue, 23 Jan 2024 07:16:36 +0000 (12:46 +0530)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 25 Jan 2024 19:47:03 +0000 (14:47 -0500)
Change the return type of "if (!bank || type == ACA_HWIP_TYPE_UNKNOW)"
to be bool instead of int.

Fixes the below:
drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c:185 aca_bank_hwip_is_matched() warn: signedness bug returning '(-22)'

Fixes: f5e4cc8461c4 ("drm/amdgpu: implement RAS ACA driver framework")
Cc: Yang Wang <kevinyang.wang@amd.com>
Cc: Hawking Zhang <Hawking.Zhang@amd.com>
Cc: Christian König <christian.koenig@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@amd.com>
Reviewed-by: Yang Wang <kevinyang.wang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c

index 8a3c3a49415d73f2f104c05efc6428be95c1347b..d2662f4d3d7585a0d44d2c05ecc31ecedff8bbc3 100644 (file)
@@ -182,7 +182,7 @@ static bool aca_bank_hwip_is_matched(struct aca_bank *bank, enum aca_hwip_type t
        u64 ipid;
 
        if (!bank || type == ACA_HWIP_TYPE_UNKNOW)
-               return -EINVAL;
+               return false;
 
        hwip = &aca_hwid_mcatypes[type];
        if (!hwip->hwid)