net: ipa: get rid of a duplicate initialization
authorAlex Elder <elder@linaro.org>
Thu, 12 May 2022 15:10:33 +0000 (10:10 -0500)
committerDavid S. Miller <davem@davemloft.net>
Fri, 13 May 2022 11:01:42 +0000 (12:01 +0100)
In ipa_qmi_ready(), the "ipa" local variable is set when
initialized, but then set again just before it's first used.
One or the other is enough, so get rid of the first one.

References: https://lore.kernel.org/lkml/200de1bd-0f01-c334-ca18-43eed783dfac@intel.com/
Reported-by: kernel test robot <lkp@intel.com>
Fixes: 530f9216a953 ("soc: qcom: ipa: AP/modem communications")
Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ipa/ipa_qmi.c

index 90f3aec55b365735051400f322cabc42e77155d8..ec010cf2e816a9f46336a66a3d52f4bb827c20fd 100644 (file)
@@ -125,7 +125,7 @@ static void ipa_qmi_indication(struct ipa_qmi *ipa_qmi)
  */
 static void ipa_qmi_ready(struct ipa_qmi *ipa_qmi)
 {
-       struct ipa *ipa = container_of(ipa_qmi, struct ipa, qmi);
+       struct ipa *ipa;
        int ret;
 
        /* We aren't ready until the modem and microcontroller are */