thermal/drivers/u8500: Remove unnecessary print function dev_err()
authorYang Li <yang.lee@linux.alibaba.com>
Tue, 19 Jul 2022 00:35:56 +0000 (08:35 +0800)
committerDaniel Lezcano <daniel.lezcano@linaro.org>
Thu, 28 Jul 2022 15:29:50 +0000 (17:29 +0200)
The print function dev_err() is redundant because platform_get_irq()
already prints an error.

Eliminate the follow coccicheck warnings:
./drivers/thermal/db8500_thermal.c:162:2-9: line 162 is redundant because platform_get_irq() already prints an error
./drivers/thermal/db8500_thermal.c:176:2-9: line 176 is redundant because platform_get_irq() already prints an error

Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Link: https://lore.kernel.org/r/20220719003556.74460-1-yang.lee@linux.alibaba.com
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
drivers/thermal/db8500_thermal.c

index ed40cfd9ab7deb9abb654adb51b04d85e53f52df..121cf853e545e41611b2ba9f76e8b6ffb8548b12 100644 (file)
@@ -158,10 +158,8 @@ static int db8500_thermal_probe(struct platform_device *pdev)
                return -ENOMEM;
 
        low_irq = platform_get_irq_byname(pdev, "IRQ_HOTMON_LOW");
-       if (low_irq < 0) {
-               dev_err(dev, "Get IRQ_HOTMON_LOW failed\n");
+       if (low_irq < 0)
                return low_irq;
-       }
 
        ret = devm_request_threaded_irq(dev, low_irq, NULL,
                prcmu_low_irq_handler, IRQF_NO_SUSPEND | IRQF_ONESHOT,
@@ -172,10 +170,8 @@ static int db8500_thermal_probe(struct platform_device *pdev)
        }
 
        high_irq = platform_get_irq_byname(pdev, "IRQ_HOTMON_HIGH");
-       if (high_irq < 0) {
-               dev_err(dev, "Get IRQ_HOTMON_HIGH failed\n");
+       if (high_irq < 0)
                return high_irq;
-       }
 
        ret = devm_request_threaded_irq(dev, high_irq, NULL,
                prcmu_high_irq_handler, IRQF_NO_SUSPEND | IRQF_ONESHOT,