usb: gadget: aspeed: Add NULL pointer check in ast_vhub_init_dev()
authorChenyuan Yang <chenyuan0y@gmail.com>
Tue, 11 Mar 2025 01:27:05 +0000 (20:27 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 14 Mar 2025 08:17:26 +0000 (09:17 +0100)
The variable d->name, returned by devm_kasprintf(), could be NULL.
A pointer check is added to prevent potential NULL pointer dereference.
This is similar to the fix in commit 3027e7b15b02
("ice: Fix some null pointer dereference issues in ice_ptp.c").

This issue is found by our static analysis tool

Signed-off-by: Chenyuan Yang <chenyuan0y@gmail.com>
Link: https://lore.kernel.org/r/20250311012705.1233829-1-chenyuan0y@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/gadget/udc/aspeed-vhub/dev.c

index 573109ca5b79902c5b396f98f58c3e87f41cc6bd..a09f72772e6e95077ac3f0573163a328d3505e06 100644 (file)
@@ -548,6 +548,9 @@ int ast_vhub_init_dev(struct ast_vhub *vhub, unsigned int idx)
        d->vhub = vhub;
        d->index = idx;
        d->name = devm_kasprintf(parent, GFP_KERNEL, "port%d", idx+1);
+       if (!d->name)
+               return -ENOMEM;
+
        d->regs = vhub->regs + 0x100 + 0x10 * idx;
 
        ast_vhub_init_ep0(vhub, &d->ep0, d);