soc: qcom: mdt_loader: Allow hash segment to be split out

It's been observed that some firmware found in a Qualcomm SM8450 device
has the hash table in a separate .bNN file. Use the newly extracted
helper function to load this segment from the separate file, if it's
determined that the hashes are not part of the already loaded firmware.

In order to do this, the function needs access to the firmware basename
and to provide more useful error messages a struct device to associate
the errors with.

Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/20220128025513.97188-4-bjorn.andersson@linaro.org

diff --git a/drivers/remoteproc/qcom_q6v5_mss.c b/drivers/remoteproc/qcom_q6v5_mss.c
index 43ea8455546ca28bce769c6b4d9ae6e2e1826797..a2c231a17b2ba4a9c9ba04eb6fbca7da9216bf65 100644 (file)
--- a/drivers/remoteproc/qcom_q6v5_mss.c
+++ b/drivers/remoteproc/qcom_q6v5_mss.c
@@ -928,7 +928,8 @@ static void q6v5proc_halt_axi_port(struct q6v5 *qproc,
        regmap_write(halt_map, offset + AXI_HALTREQ_REG, 0);
 }
 
-static int q6v5_mpss_init_image(struct q6v5 *qproc, const struct firmware *fw)
+static int q6v5_mpss_init_image(struct q6v5 *qproc, const struct firmware *fw,
+                               const char *fw_name)
 {
        unsigned long dma_attrs = DMA_ATTR_FORCE_CONTIGUOUS;
        dma_addr_t phys;
@@ -939,7 +940,7 @@ static int q6v5_mpss_init_image(struct q6v5 *qproc, const struct firmware *fw)
        void *ptr;
        int ret;
 
-       metadata = qcom_mdt_read_metadata(fw, &size);
+       metadata = qcom_mdt_read_metadata(fw, &size, fw_name, qproc->dev);
        if (IS_ERR(metadata))
                return PTR_ERR(metadata);
 
@@ -1289,7 +1290,7 @@ static int q6v5_mpss_load(struct q6v5 *qproc)
        /* Initialize the RMB validator */
        writel(0, qproc->rmb_base + RMB_PMI_CODE_LENGTH_REG);
 
-       ret = q6v5_mpss_init_image(qproc, fw);
+       ret = q6v5_mpss_init_image(qproc, fw, qproc->hexagon_mdt_image);
        if (ret)
                goto release_firmware;
 

diff --git a/drivers/soc/qcom/mdt_loader.c b/drivers/soc/qcom/mdt_loader.c
index c9e5bdfac371b4f00e3a3b292f024e1288b64f38..4372d8e38b29c3e7dc1f9bd063b40584419f0725 100644 (file)
--- a/drivers/soc/qcom/mdt_loader.c
+++ b/drivers/soc/qcom/mdt_loader.c
@@ -121,13 +121,15 @@ EXPORT_SYMBOL_GPL(qcom_mdt_get_size);
  *
  * Return: pointer to data, or ERR_PTR()
  */
-void *qcom_mdt_read_metadata(const struct firmware *fw, size_t *data_len)
+void *qcom_mdt_read_metadata(const struct firmware *fw, size_t *data_len,
+                            const char *fw_name, struct device *dev)
 {
        const struct elf32_phdr *phdrs;
        const struct elf32_hdr *ehdr;
        size_t hash_offset;
        size_t hash_size;
        size_t ehdr_size;
+       ssize_t ret;
        void *data;
 
        ehdr = (struct elf32_hdr *)fw->data;
@@ -149,14 +151,25 @@ void *qcom_mdt_read_metadata(const struct firmware *fw, size_t *data_len)
        if (!data)
                return ERR_PTR(-ENOMEM);
 
-       /* Is the header and hash already packed */
-       if (ehdr_size + hash_size == fw->size)
+       /* Copy ELF header */
+       memcpy(data, fw->data, ehdr_size);
+
+       if (ehdr_size + hash_size == fw->size) {
+               /* Firmware is split and hash is packed following the ELF header */
                hash_offset = phdrs[0].p_filesz;
-       else
+               memcpy(data + ehdr_size, fw->data + hash_offset, hash_size);
+       } else if (phdrs[1].p_offset + hash_size <= fw->size) {
+               /* Hash is in its own segment, but within the loaded file */
                hash_offset = phdrs[1].p_offset;
-
-       memcpy(data, fw->data, ehdr_size);
-       memcpy(data + ehdr_size, fw->data + hash_offset, hash_size);
+               memcpy(data + ehdr_size, fw->data + hash_offset, hash_size);
+       } else {
+               /* Hash is in its own segment, beyond the loaded file */
+               ret = mdt_load_split_segment(data + ehdr_size, phdrs, 1, fw_name, dev);
+               if (ret) {
+                       kfree(data);
+                       return ERR_PTR(ret);
+               }
+       }
 
        *data_len = ehdr_size + hash_size;
 
@@ -190,7 +203,7 @@ static int __qcom_mdt_load(struct device *dev, const struct firmware *fw,
        phdrs = (struct elf32_phdr *)(ehdr + 1);
 
        if (pas_init) {
-               metadata = qcom_mdt_read_metadata(fw, &metadata_len);
+               metadata = qcom_mdt_read_metadata(fw, &metadata_len, fw_name, dev);
                if (IS_ERR(metadata)) {
                        ret = PTR_ERR(metadata);
                        dev_err(dev, "error %d reading firmware %s metadata\n",

diff --git a/include/linux/soc/qcom/mdt_loader.h b/include/linux/soc/qcom/mdt_loader.h
index afd47217996b0beb6a2594f744fdb7139f1d2607..46bdb7bace9ae98dab261fa9a4a045e900106544 100644 (file)
--- a/include/linux/soc/qcom/mdt_loader.h
+++ b/include/linux/soc/qcom/mdt_loader.h
@@ -23,7 +23,8 @@ int qcom_mdt_load_no_init(struct device *dev, const struct firmware *fw,
                          const char *fw_name, int pas_id, void *mem_region,
                          phys_addr_t mem_phys, size_t mem_size,
                          phys_addr_t *reloc_base);
-void *qcom_mdt_read_metadata(const struct firmware *fw, size_t *data_len);
+void *qcom_mdt_read_metadata(const struct firmware *fw, size_t *data_len,
+                            const char *fw_name, struct device *dev);
 
 #else /* !IS_ENABLED(CONFIG_QCOM_MDT_LOADER) */
 
@@ -51,7 +52,8 @@ static inline int qcom_mdt_load_no_init(struct device *dev,
 }
 
 static inline void *qcom_mdt_read_metadata(const struct firmware *fw,
-                                          size_t *data_len)
+                                          size_t *data_len, const char *fw_name,
+                                          struct device *dev)
 {
        return ERR_PTR(-ENODEV);
 }