ASoC: imx-audmix: fix object reference leaks in probe
authorViorel Suman <viorel.suman@nxp.com>
Wed, 10 Apr 2019 11:06:38 +0000 (11:06 +0000)
committerMark Brown <broonie@kernel.org>
Thu, 2 May 2019 01:46:14 +0000 (10:46 +0900)
Release the reference to the underlying device taken
by of_find_device_by_node() call.

Signed-off-by: Viorel Suman <viorel.suman@nxp.com>
Reported-by: Julia Lawall <Julia.Lawall@lip6.fr>
Acked-by: Nicolin Chen <nicoleotsuka@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/fsl/imx-audmix.c

index 7983bd339c0114cafd434c75442c2646fe7db222..9aaf3e5b45b953d7948184ee86dc8b72a7e07246 100644 (file)
@@ -171,6 +171,7 @@ static int imx_audmix_probe(struct platform_device *pdev)
                        np->full_name);
                return -EINVAL;
        }
+       put_device(&audmix_pdev->dev);
 
        num_dai = of_count_phandle_with_args(audmix_np, "dais", NULL);
        if (num_dai != FSL_AUDMIX_MAX_DAIS) {
@@ -216,6 +217,7 @@ static int imx_audmix_probe(struct platform_device *pdev)
                        dev_err(&pdev->dev, "failed to find SAI platform device\n");
                        return -EINVAL;
                }
+               put_device(&cpu_pdev->dev);
 
                dai_name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "%s%s",
                                          fe_name_pref, args.np->full_name + 1);
@@ -280,6 +282,8 @@ static int imx_audmix_probe(struct platform_device *pdev)
                dev_err(&pdev->dev, "failed to find SAI platform device\n");
                return -EINVAL;
        }
+       put_device(&cpu_pdev->dev);
+
        priv->cpu_mclk = devm_clk_get(&cpu_pdev->dev, "mclk1");
        if (IS_ERR(priv->cpu_mclk)) {
                ret = PTR_ERR(priv->cpu_mclk);