ARM64 / cpuidle: Use new cpuidle macro for entering retention state
authorPrashanth Prakash <pprakash@codeaurora.org>
Wed, 15 Nov 2017 17:11:50 +0000 (10:11 -0700)
committerCatalin Marinas <catalin.marinas@arm.com>
Tue, 2 Jan 2018 13:50:34 +0000 (13:50 +0000)
CPU_PM_CPU_IDLE_ENTER_RETENTION skips calling cpu_pm_enter() and
cpu_pm_exit(). By not calling cpu_pm functions in idle entry/exit
paths we can reduce the latency involved in entering and exiting
the low power idle state.

On ARM64 based Qualcomm server platform we measured below overhead
for calling cpu_pm_enter and cpu_pm_exit for retention states.

workload: stress --hdd #CPUs --hdd-bytes 32M  -t 30
Average overhead of cpu_pm_enter - 1.2us
Average overhead of cpu_pm_exit  - 3.1us

Acked-by: Sudeep Holla <sudeep.holla@arm.com>
Signed-off-by: Prashanth Prakash <pprakash@codeaurora.org>
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
arch/arm64/kernel/cpuidle.c

index fd691087dc9ad58ff0ff007f5ea7191a3f879380..f2d13810daa8fc28449be12138e398a14275fc9a 100644 (file)
@@ -47,6 +47,8 @@ int arm_cpuidle_suspend(int index)
 
 #include <acpi/processor.h>
 
+#define ARM64_LPI_IS_RETENTION_STATE(arch_flags) (!(arch_flags))
+
 int acpi_processor_ffh_lpi_probe(unsigned int cpu)
 {
        return arm_cpuidle_init(cpu);
@@ -54,6 +56,10 @@ int acpi_processor_ffh_lpi_probe(unsigned int cpu)
 
 int acpi_processor_ffh_lpi_enter(struct acpi_lpi_state *lpi)
 {
-       return CPU_PM_CPU_IDLE_ENTER(arm_cpuidle_suspend, lpi->index);
+       if (ARM64_LPI_IS_RETENTION_STATE(lpi->arch_flags))
+               return CPU_PM_CPU_IDLE_ENTER_RETENTION(arm_cpuidle_suspend,
+                                               lpi->index);
+       else
+               return CPU_PM_CPU_IDLE_ENTER(arm_cpuidle_suspend, lpi->index);
 }
 #endif