platform/x86: dell-wmi-descriptor: check if memory was allocated
authorMario Limonciello <mario.limonciello@dell.com>
Thu, 9 Nov 2017 17:49:09 +0000 (11:49 -0600)
committerDarren Hart (VMware) <dvhart@infradead.org>
Fri, 17 Nov 2017 01:45:26 +0000 (17:45 -0800)
devm_kzalloc will return NULL pointer if no memory was allocated.
This should be checked.  This problem also existed when the driver
was dell-wmi.c.

Signed-off-by: Mario Limonciello <mario.limonciello@dell.com>
Reviewed-by: Pali Rohár <pali.rohar@gmail.com>
Signed-off-by: Darren Hart (VMware) <dvhart@infradead.org>
drivers/platform/x86/dell-wmi-descriptor.c

index 3204c408e261dd77d2998eb2f2febd8f41b6bce5..28ef5f37cfbf056168ba703874a1a70957cd7b4c 100644 (file)
@@ -121,6 +121,11 @@ static int dell_wmi_descriptor_probe(struct wmi_device *wdev)
        priv = devm_kzalloc(&wdev->dev, sizeof(struct descriptor_priv),
        GFP_KERNEL);
 
+       if (!priv) {
+               ret = -ENOMEM;
+               goto out;
+       }
+
        priv->interface_version = buffer[2];
        priv->size = buffer[3];
        ret = 0;