geneve: Initialize addr6 with memset
authorNathan Chancellor <natechancellor@gmail.com>
Sat, 17 Nov 2018 01:36:27 +0000 (18:36 -0700)
committerDavid S. Miller <davem@davemloft.net>
Sun, 18 Nov 2018 06:03:06 +0000 (22:03 -0800)
Clang warns:

drivers/net/geneve.c:428:29: error: suggest braces around initialization
of subobject [-Werror,-Wmissing-braces]
                struct in6_addr addr6 = { 0 };
                                          ^
                                          {}

Rather than trying to appease the various compilers that support the
kernel, use memset, which is unambiguous.

Fixes: a07966447f39 ("geneve: ICMP error lookup handler")
Suggested-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/geneve.c

index 7c53e06b31c32365440c6fbf0c3261e5a679937b..58bbba8582b0960de94296ccbbed9c074b12aed0 100644 (file)
@@ -425,7 +425,9 @@ static int geneve_udp_encap_err_lookup(struct sock *sk, struct sk_buff *skb)
 #if IS_ENABLED(CONFIG_IPV6)
        if (geneve_get_sk_family(gs) == AF_INET6) {
                struct ipv6hdr *ip6h = ipv6_hdr(skb);
-               struct in6_addr addr6 = { 0 };
+               struct in6_addr addr6;
+
+               memset(&addr6, 0, sizeof(struct in6_addr));
 
                if (!gs->collect_md) {
                        vni = geneve_hdr(skb)->vni;