mm/hmm: Use lockdep instead of comments
authorJason Gunthorpe <jgg@mellanox.com>
Thu, 23 May 2019 14:23:30 +0000 (11:23 -0300)
committerJason Gunthorpe <jgg@mellanox.com>
Tue, 18 Jun 2019 15:13:06 +0000 (12:13 -0300)
So we can check locking at runtime.

Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
Reviewed-by: Jérôme Glisse <jglisse@redhat.com>
Reviewed-by: John Hubbard <jhubbard@nvidia.com>
Reviewed-by: Ralph Campbell <rcampbell@nvidia.com>
Acked-by: Souptick Joarder <jrdr.linux@gmail.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Tested-by: Philip Yang <Philip.Yang@amd.com>
mm/hmm.c

index 1eddda45cefae79029493ff34f041b335315b417..6f5dc6d568feb106030f3c0032a061c827ebac51 100644 (file)
--- a/mm/hmm.c
+++ b/mm/hmm.c
@@ -246,11 +246,11 @@ static const struct mmu_notifier_ops hmm_mmu_notifier_ops = {
  *
  * To start mirroring a process address space, the device driver must register
  * an HMM mirror struct.
- *
- * THE mm->mmap_sem MUST BE HELD IN WRITE MODE !
  */
 int hmm_mirror_register(struct hmm_mirror *mirror, struct mm_struct *mm)
 {
+       lockdep_assert_held_exclusive(&mm->mmap_sem);
+
        /* Sanity check */
        if (!mm || !mirror || !mirror->ops)
                return -EINVAL;