kbuild: move W=1 check for scripts/misc-check to top-level Makefile

This script is executed only when ${KBUILD_EXTRA_WARN} contains 1.
Move this check to the top-level Makefile to allow more checks to be
easily added to this script.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>

diff --git a/Makefile b/Makefile
index 9a104f02ce25c7fb0fae6eca45ab8aaa18004b0e..fe2f1cb4d9b7fca4b8eed422a83f0f47474de90c 100644 (file)
--- a/Makefile
+++ b/Makefile
@@ -1827,9 +1827,12 @@ rustfmtcheck: rustfmt
 # Misc
 # ---------------------------------------------------------------------------
 
+# Run misc checks when ${KBUILD_EXTRA_WARN} contains 1
 PHONY += misc-check
+ifneq ($(findstring 1,$(KBUILD_EXTRA_WARN)),)
 misc-check:
        $(Q)$(srctree)/scripts/misc-check
+endif
 
 all: misc-check
 

diff --git a/scripts/misc-check b/scripts/misc-check
index d40d5484e0c50da1414c5628c9b4b58d68451bd0..f37b2f6931cc2fcd05e1deae88d46a10cb41d286 100755 (executable)
--- a/scripts/misc-check
+++ b/scripts/misc-check
@@ -3,15 +3,8 @@
 
 set -e
 
-# Detect files that are tracked but ignored by git. This is checked only when
-# ${KBUILD_EXTRA_WARN} contains 1, git is installed, and the source tree is
-# tracked by git.
+# Detect files that are tracked but ignored by git.
 check_tracked_ignored_files () {
-       case "${KBUILD_EXTRA_WARN}" in
-       *1*) ;;
-       *) return;;
-       esac
-
        git -C ${srctree:-.} ls-files -i -c --exclude-per-directory=.gitignore 2>/dev/null |
                sed 's/$/: warning: ignored by one of the .gitignore files/' >&2
 }