drm/i915: pass dev_priv explicitly to DSPSURFLIVE
authorJani Nikula <jani.nikula@intel.com>
Thu, 23 May 2024 12:59:39 +0000 (15:59 +0300)
committerJani Nikula <jani.nikula@intel.com>
Fri, 24 May 2024 07:41:05 +0000 (10:41 +0300)
Avoid the implicit dev_priv local variable use, and pass dev_priv
explicitly to the DSPSURFLIVE register macro.

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/bc252dee67718f729883da7d542c6435384683ae.1716469091.git.jani.nikula@intel.com
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
drivers/gpu/drm/i915/display/i9xx_plane_regs.h
drivers/gpu/drm/i915/gvt/handlers.c
drivers/gpu/drm/i915/intel_gvt_mmio_table.c

index 0930a76ccf3cfabfc7e1e7898d0fb70e91704243..22a550c8b41ad2f36df245396c818b82b2f29411 100644 (file)
@@ -81,7 +81,7 @@
 #define DSPOFFSET(dev_priv, plane)             _MMIO_PIPE2(dev_priv, plane, _DSPAOFFSET)
 
 #define _DSPASURFLIVE                          0x701AC /* g4x+ */
-#define DSPSURFLIVE(plane)                     _MMIO_PIPE2(dev_priv, plane, _DSPASURFLIVE)
+#define DSPSURFLIVE(dev_priv, plane)           _MMIO_PIPE2(dev_priv, plane, _DSPASURFLIVE)
 
 #define _DSPAGAMC                              0x701E0 /* pre-g4x */
 #define DSPGAMC(plane, i)                      _MMIO_PIPE2(dev_priv, plane, _DSPAGAMC + (5 - (i)) * 4) /* plane C only, 6 x u0.8 */
index abcb8f0825e054c7b491e4c647c82a71a5e1a713..840fea160aa622ea336bab69d64b7b80c206cc54 100644 (file)
@@ -1018,7 +1018,7 @@ static int pri_surf_mmio_write(struct intel_vgpu *vgpu, unsigned int offset,
        int event = SKL_FLIP_EVENT(pipe, PLANE_PRIMARY);
 
        write_vreg(vgpu, offset, p_data, bytes);
-       vgpu_vreg_t(vgpu, DSPSURFLIVE(pipe)) = vgpu_vreg(vgpu, offset);
+       vgpu_vreg_t(vgpu, DSPSURFLIVE(dev_priv, pipe)) = vgpu_vreg(vgpu, offset);
 
        vgpu_vreg_t(vgpu, PIPE_FLIPCOUNT_G4X(pipe))++;
 
@@ -1061,7 +1061,7 @@ static int reg50080_mmio_write(struct intel_vgpu *vgpu,
 
        write_vreg(vgpu, offset, p_data, bytes);
        if (plane == PLANE_PRIMARY) {
-               vgpu_vreg_t(vgpu, DSPSURFLIVE(pipe)) = vgpu_vreg(vgpu, offset);
+               vgpu_vreg_t(vgpu, DSPSURFLIVE(dev_priv, pipe)) = vgpu_vreg(vgpu, offset);
                vgpu_vreg_t(vgpu, PIPE_FLIPCOUNT_G4X(pipe))++;
        } else {
                vgpu_vreg_t(vgpu, SPRSURFLIVE(pipe)) = vgpu_vreg(vgpu, offset);
index 50dfe1f81b996912e62821a8b8aaddae4c7417db..b4d5592b18df3709cc2b10b2129e10a27e9c33cf 100644 (file)
@@ -172,7 +172,7 @@ static int iterate_generic_mmio(struct intel_gvt_mmio_table_iter *iter)
        MMIO_D(DSPSIZE(dev_priv, PIPE_A));
        MMIO_D(DSPSURF(dev_priv, PIPE_A));
        MMIO_D(DSPOFFSET(dev_priv, PIPE_A));
-       MMIO_D(DSPSURFLIVE(PIPE_A));
+       MMIO_D(DSPSURFLIVE(dev_priv, PIPE_A));
        MMIO_D(REG_50080(PIPE_A, PLANE_PRIMARY));
        MMIO_D(DSPCNTR(dev_priv, PIPE_B));
        MMIO_D(DSPADDR(dev_priv, PIPE_B));
@@ -181,7 +181,7 @@ static int iterate_generic_mmio(struct intel_gvt_mmio_table_iter *iter)
        MMIO_D(DSPSIZE(dev_priv, PIPE_B));
        MMIO_D(DSPSURF(dev_priv, PIPE_B));
        MMIO_D(DSPOFFSET(dev_priv, PIPE_B));
-       MMIO_D(DSPSURFLIVE(PIPE_B));
+       MMIO_D(DSPSURFLIVE(dev_priv, PIPE_B));
        MMIO_D(REG_50080(PIPE_B, PLANE_PRIMARY));
        MMIO_D(DSPCNTR(dev_priv, PIPE_C));
        MMIO_D(DSPADDR(dev_priv, PIPE_C));
@@ -190,7 +190,7 @@ static int iterate_generic_mmio(struct intel_gvt_mmio_table_iter *iter)
        MMIO_D(DSPSIZE(dev_priv, PIPE_C));
        MMIO_D(DSPSURF(dev_priv, PIPE_C));
        MMIO_D(DSPOFFSET(dev_priv, PIPE_C));
-       MMIO_D(DSPSURFLIVE(PIPE_C));
+       MMIO_D(DSPSURFLIVE(dev_priv, PIPE_C));
        MMIO_D(REG_50080(PIPE_C, PLANE_PRIMARY));
        MMIO_D(SPRCTL(PIPE_A));
        MMIO_D(SPRLINOFF(PIPE_A));