kernel/compat.c: mark expected switch fall-throughs
authorStephen Rothwell <sfr@canb.auug.org.au>
Wed, 15 May 2019 05:23:52 +0000 (15:23 +1000)
committerLinus Torvalds <torvalds@linux-foundation.org>
Wed, 15 May 2019 15:16:14 +0000 (08:16 -0700)
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

This patch aims to suppress 3 missing-break-in-switch false positives
on some architectures.

Acked-by: Arnd Bergmann <arnd@arndb.de>
Cc: Deepa Dinamani <deepa.kernel@gmail.com>
Cc: Gustavo A. R. Silva <gustavo@embeddedor.com>
Cc: Kees Cook <keescook@chromium.org>
Cc: Jann Horn <jannh@google.com>
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
kernel/compat.c

index d8a36c6ad7c91046ff71bd1833ded3c0f2d989a6..b5f7063c0db60dd192ca1f882e492ff16a7477f1 100644 (file)
@@ -346,8 +346,11 @@ get_compat_sigset(sigset_t *set, const compat_sigset_t __user *compat)
                return -EFAULT;
        switch (_NSIG_WORDS) {
        case 4: set->sig[3] = v.sig[6] | (((long)v.sig[7]) << 32 );
+               /* fall through */
        case 3: set->sig[2] = v.sig[4] | (((long)v.sig[5]) << 32 );
+               /* fall through */
        case 2: set->sig[1] = v.sig[2] | (((long)v.sig[3]) << 32 );
+               /* fall through */
        case 1: set->sig[0] = v.sig[0] | (((long)v.sig[1]) << 32 );
        }
 #else