arm64: dts: mediatek: mt8173: Enable cros-ec-spi as wake source
authorMark Hasemeyer <markhas@chromium.org>
Tue, 2 Jan 2024 21:07:33 +0000 (14:07 -0700)
committerAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Mon, 12 Feb 2024 12:36:58 +0000 (13:36 +0100)
The cros_ec driver currently assumes that cros-ec-spi compatible device
nodes are a wakeup-source even though the wakeup-source property is not
defined.

Some Chromebooks use a separate wake pin, while others overload the
interrupt for wake and IO. With the current assumption, spurious wakes
can occur on systems that use a separate wake pin. It is planned to
update the driver to no longer assume that the EC interrupt pin should
be enabled for wake.

Add the wakeup-source property to all cros-ec-spi compatible device
nodes to signify to the driver that they should still be a valid wakeup
source.

Signed-off-by: Mark Hasemeyer <markhas@chromium.org>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://lore.kernel.org/r/20240102140734.v4.9.Ic09ebe116c18e83cc1161f4bb073fea8043f03f3@changeid
Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi

index 8d614ac2c58ed8262e468a9239b5692f767c6ac2..335aed42dc9e37af603030d5e86bccfa0f411eca 100644 (file)
                spi-max-frequency = <12000000>;
                interrupts-extended = <&pio 0 IRQ_TYPE_LEVEL_LOW>;
                google,cros-ec-spi-msg-delay = <500>;
+               wakeup-source;
 
                i2c_tunnel: i2c-tunnel0 {
                        compatible = "google,cros-ec-i2c-tunnel";