qlcnic: remove set but not used variables 'op, cmd_op'
authorYueHaibing <yuehaibing@huawei.com>
Mon, 17 Dec 2018 09:27:16 +0000 (17:27 +0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 18 Dec 2018 23:49:46 +0000 (15:49 -0800)
Fixes gcc '-Wunused-but-set-variable' warning:

drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_pf.c:1070:5: warning:
 variable 'op' set but not used [-Wunused-but-set-variable]
drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_pf.c:1342:5: warning:
 variable 'cmd_op' set but not used [-Wunused-but-set-variable]

'op' never used since introduction in commit 7cb03b2347d5 ("qlcnic:
Support VF-PF communication channel commands.")
'cmd_op' not used since commit 6226204bcf20 ("qlcnic: Fix operation
type and command type.")

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_pf.c

index 50eaafa3eaba362d0ed9b35821234dcf2551e03f..af3b037fa44286580b574f7978af3ad3d2decdc5 100644 (file)
@@ -1067,9 +1067,6 @@ static int qlcnic_sriov_pf_cfg_ip_cmd(struct qlcnic_bc_trans *trans,
        struct qlcnic_vf_info *vf = trans->vf;
        struct qlcnic_adapter *adapter = vf->adapter;
        int err = -EIO;
-       u8 op;
-
-       op =  cmd->req.arg[1] & 0xff;
 
        cmd->req.arg[1] |= vf->vp->handle << 16;
        cmd->req.arg[1] |= BIT_31;
@@ -1339,14 +1336,13 @@ static int qlcnic_sriov_pf_get_acl_cmd(struct qlcnic_bc_trans *trans,
 {
        struct qlcnic_vf_info *vf = trans->vf;
        struct qlcnic_vport *vp = vf->vp;
-       u8 cmd_op, mode = vp->vlan_mode;
+       u8 mode = vp->vlan_mode;
        struct qlcnic_adapter *adapter;
        struct qlcnic_sriov *sriov;
 
        adapter = vf->adapter;
        sriov = adapter->ahw->sriov;
 
-       cmd_op = trans->req_hdr->cmd_op;
        cmd->rsp.arg[0] |= 1 << 25;
 
        /* For 84xx adapter in case of PVID , PFD should send vlan mode as