media: atomisp: register first the preview devnode

The atomisp currenyl registers 5 pairs of devices each one
for one different run_mode, plus one for "ACC". The only
one that behaves like a normal V4L2 device is the preview
one. The others are doing weird things, and perhaps are
using some proprietary extensions to the API.

Change the device order to start with the preview one,
e. g:

	/dev/video0: ATOMISP ISP PREVIEW output
	/dev/video1: ATOMISP ISP CAPTURE output
	/dev/video2: ATOMISP ISP VIEWFINDER output
	/dev/video3: ATOMISP ISP VIDEO output
	/dev/video4: ATOMISP ACC

This way, a normal V4L2 application will get the right
device, as the first one will be the one they should use.

Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

diff --git a/drivers/staging/media/atomisp/pci/atomisp_subdev.c b/drivers/staging/media/atomisp/pci/atomisp_subdev.c
index ffaf11e0b0ad8161f84d3362157c75f7ca3cff79..a3f3c42f9db7abbdccf061ededa0bb25ac053b53 100644 (file)
--- a/drivers/staging/media/atomisp/pci/atomisp_subdev.c
+++ b/drivers/staging/media/atomisp/pci/atomisp_subdev.c
@@ -1356,6 +1356,14 @@ int atomisp_subdev_register_entities(struct atomisp_sub_device *asd,
        if (ret < 0)
                goto error;
 
+       asd->video_out_preview.vdev.v4l2_dev = vdev;
+       asd->video_out_preview.vdev.device_caps = device_caps |
+                                                 V4L2_CAP_VIDEO_OUTPUT;
+       ret = video_register_device(&asd->video_out_preview.vdev,
+                                   VFL_TYPE_VIDEO, -1);
+       if (ret < 0)
+               goto error;
+
        asd->video_out_capture.vdev.v4l2_dev = vdev;
        asd->video_out_capture.vdev.device_caps = device_caps |
                                                  V4L2_CAP_VIDEO_OUTPUT;
@@ -1371,13 +1379,7 @@ int atomisp_subdev_register_entities(struct atomisp_sub_device *asd,
                                    VFL_TYPE_VIDEO, -1);
        if (ret < 0)
                goto error;
-       asd->video_out_preview.vdev.v4l2_dev = vdev;
-       asd->video_out_preview.vdev.device_caps = device_caps |
-                                                 V4L2_CAP_VIDEO_OUTPUT;
-       ret = video_register_device(&asd->video_out_preview.vdev,
-                                   VFL_TYPE_VIDEO, -1);
-       if (ret < 0)
-               goto error;
+
        asd->video_out_video_capture.vdev.v4l2_dev = vdev;
        asd->video_out_video_capture.vdev.device_caps = device_caps |
                                                        V4L2_CAP_VIDEO_OUTPUT;