drm/xe: Restore EIO errno return when GuC PC start fails
authorRodrigo Vivi <rodrigo.vivi@intel.com>
Fri, 28 Mar 2025 18:17:52 +0000 (14:17 -0400)
committerLucas De Marchi <lucas.demarchi@intel.com>
Mon, 7 Apr 2025 21:00:27 +0000 (14:00 -0700)
Commit b4b05e53b550 ("drm/xe/guc_pc: Retry and wait longer for GuC PC
start"), leads to the following Smatch static checker warning:

        drivers/gpu/drm/xe/xe_guc_pc.c:1073 xe_guc_pc_start()
        warn: missing error code here? '_dev_err()' failed. 'ret' = '0'

Fixes: c605acb53f44 ("drm/xe/guc_pc: Retry and wait longer for GuC PC start")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/intel-xe/1454a5f1-ee18-4df1-a6b2-a4a3dddcd1cb@stanley.mountain/
Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
Link: https://lore.kernel.org/r/20250328181752.26677-1-rodrigo.vivi@intel.com
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
(cherry picked from commit 3f2bdccbccdcb53b0d316474eafff2e3462a51ad)
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
drivers/gpu/drm/xe/xe_guc_pc.c

index 85215313976ce4e404a4aa329053925c6ef549a5..43b1192ba61cde55a07e0481bb393362a985c790 100644 (file)
@@ -1070,6 +1070,7 @@ int xe_guc_pc_start(struct xe_guc_pc *pc)
                if (wait_for_pc_state(pc, SLPC_GLOBAL_STATE_RUNNING,
                                      SLPC_RESET_EXTENDED_TIMEOUT_MS)) {
                        xe_gt_err(gt, "GuC PC Start failed: Dynamic GT frequency control and GT sleep states are now disabled.\n");
+                       ret = -EIO;
                        goto out;
                }