ALSA: usb-audio: qcom: fix USB_XHCI dependency
authorArnd Bergmann <arnd@arndb.de>
Wed, 21 May 2025 13:55:43 +0000 (15:55 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 23 May 2025 12:38:50 +0000 (14:38 +0200)
SND_USB_AUDIO_QMI depends on USB_XHCI_SIDEBAND, but that is a bool symbol
and allows it to be built-in even when XHCI itself is in a loadable module.
That configuration causes a link failure:

arm-linux-gnueabi-ld: sound/usb/qcom/qc_audio_offload.o: in function `uaudio_event_ring_cleanup_free':
qc_audio_offload.c:(.text+0x7dc): undefined reference to `xhci_sideband_remove_interrupter'
arm-linux-gnueabi-ld: sound/usb/qcom/qc_audio_offload.o: in function `uaudio_endpoint_setup':
qc_audio_offload.c:(.text+0xe88): undefined reference to `xhci_sideband_add_endpoint'

Add the extra dependency on USB_XHCI itself.

Fixes: 326bbc348298 ("ALSA: usb-audio: qcom: Introduce QC USB SND offloading support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20250521135551.2111109-1-arnd@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/usb/Kconfig

index 6daa551738dab0f6c7f493499b9b1705335f4d99..41c47301bc19c968906b57757b5dba1b9937e5b4 100644 (file)
@@ -178,7 +178,8 @@ config SND_BCD2000
 
 config SND_USB_AUDIO_QMI
        tristate "Qualcomm Audio Offload driver"
-       depends on QCOM_QMI_HELPERS && SND_USB_AUDIO && USB_XHCI_SIDEBAND && SND_SOC_USB
+       depends on QCOM_QMI_HELPERS && SND_USB_AUDIO && SND_SOC_USB
+       depends on USB_XHCI_HCD && USB_XHCI_SIDEBAND
        help
          Say Y here to enable the Qualcomm USB audio offloading feature.