projects
/
linux-block.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
962297a
)
ALSA: intel8x0: Fix incorrect codec index usage in mixer for ICH4
author
Alok Tiwari
<alok.a.tiwari@oracle.com>
Sat, 21 Jun 2025 18:52:24 +0000
(11:52 -0700)
committer
Takashi Iwai
<tiwai@suse.de>
Sun, 22 Jun 2025 09:28:12 +0000
(11:28 +0200)
code mistakenly used a hardcoded index (codec[1]) instead of
iterating, over the codec array using the loop variable i.
Use codec[i] instead of codec[1] to match the loop iteration.
Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Link:
https://patch.msgid.link/20250621185233.4081094-1-alok.a.tiwari@oracle.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/intel8x0.c
patch
|
blob
|
blame
|
history
diff --git
a/sound/pci/intel8x0.c
b/sound/pci/intel8x0.c
index 51e7f1f1a48e45956d808f20d4075e932ba63bfa..b521cec2033361b59b7abf5012ec65c532d9d7a3 100644
(file)
--- a/
sound/pci/intel8x0.c
+++ b/
sound/pci/intel8x0.c
@@
-2249,7
+2249,7
@@
static int snd_intel8x0_mixer(struct intel8x0 *chip, int ac97_clock,
tmp |= chip->ac97_sdin[0] << ICH_DI1L_SHIFT;
for (i = 1; i < 4; i++) {
if (pcm->r[0].codec[i]) {
- tmp |= chip->ac97_sdin[pcm->r[0].codec[
1
]->num] << ICH_DI2L_SHIFT;
+ tmp |= chip->ac97_sdin[pcm->r[0].codec[
i
]->num] << ICH_DI2L_SHIFT;
break;
}
}