media: mtk-vpu: no need to check return value of debugfs_create functions
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 18 Aug 2020 13:36:05 +0000 (15:36 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Tue, 1 Sep 2020 12:13:26 +0000 (14:13 +0200)
When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/platform/mtk-vpu/mtk_vpu.c

index d30c08983f56d9532907dd5754ff8ccc31270c80..36cb9b6131f7e2ecc0a79ce731e3fff090684d7d 100644 (file)
@@ -849,10 +849,6 @@ static int mtk_vpu_probe(struct platform_device *pdev)
 #ifdef CONFIG_DEBUG_FS
        vpu_debugfs = debugfs_create_file("mtk_vpu", S_IRUGO, NULL, (void *)dev,
                                          &vpu_debug_fops);
-       if (!vpu_debugfs) {
-               ret = -ENOMEM;
-               goto cleanup_ipi;
-       }
 #endif
 
        /* Set PTCM to 96K and DTCM to 32K */
@@ -910,7 +906,6 @@ remove_debugfs:
        of_reserved_mem_device_release(dev);
 #ifdef CONFIG_DEBUG_FS
        debugfs_remove(vpu_debugfs);
-cleanup_ipi:
 #endif
        memset(vpu->ipi_desc, 0, sizeof(struct vpu_ipi_desc) * IPI_MAX);
 vpu_mutex_destroy: