ALSA: bebob: obsolete useless member of private structure
authorTakashi Sakamoto <o-takashi@sakamocchi.jp>
Wed, 12 Jun 2019 08:44:06 +0000 (17:44 +0900)
committerTakashi Iwai <tiwai@suse.de>
Wed, 12 Jun 2019 13:26:48 +0000 (15:26 +0200)
The private structure of this driver has 'connected' member but nowadays
it's useless. This commit removes it.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/firewire/bebob/bebob.h
sound/firewire/bebob/bebob_stream.c

index c30ed44aced9c5c2faa2116c59d1b41b012765f4..20ed2dbd8d6121f0c515d3fee1d71173a9999285 100644 (file)
@@ -93,8 +93,6 @@ struct snd_bebob {
        unsigned int midi_input_ports;
        unsigned int midi_output_ports;
 
-       bool connected;
-
        struct amdtp_stream tx_stream;
        struct amdtp_stream rx_stream;
        struct cmp_connection out_conn;
index d6e7f13ef42d1bacd6dac5dc47d073adbce5738f..c3cc31df49e0d52ac48fb5b22373528bae860e96 100644 (file)
@@ -422,9 +422,6 @@ static int make_both_connections(struct snd_bebob *bebob)
 {
        int err = 0;
 
-       if (bebob->connected)
-               return 0;
-
        err = cmp_connection_establish(&bebob->out_conn,
                        amdtp_stream_get_max_payload(&bebob->tx_stream));
        if (err < 0)
@@ -437,8 +434,6 @@ static int make_both_connections(struct snd_bebob *bebob)
                return err;
        }
 
-       bebob->connected = true;
-
        return 0;
 }
 
@@ -448,8 +443,6 @@ break_both_connections(struct snd_bebob *bebob)
        cmp_connection_break(&bebob->in_conn);
        cmp_connection_break(&bebob->out_conn);
 
-       bebob->connected = false;
-
        /* These models seems to be in transition state for a longer time. */
        if (bebob->maudio_special_quirk != NULL)
                msleep(200);