wcn36xx: harmless memory corruption bug in debugfs
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 6 Nov 2013 07:41:28 +0000 (10:41 +0300)
committerJohn W. Linville <linville@tuxdriver.com>
Mon, 11 Nov 2013 19:42:46 +0000 (14:42 -0500)
On 64 bit systems we write past the end of the arg[] array.

Fixes: 8e84c2582169 ('wcn36xx: mac80211 driver for Qualcomm WCN3660/WCN3680 hardware')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/ath/wcn36xx/debug.c

index 5b84f7ae0b1e3820cdee9737f9e4bacd8ed7b8d3..ef44a2da644d47be1613041703093cf7567f8979 100644 (file)
@@ -126,7 +126,7 @@ static ssize_t write_file_dump(struct file *file,
                if (begin == NULL)
                        break;
 
-               if (kstrtoul(begin, 0, (unsigned long *)(arg + i)) != 0)
+               if (kstrtou32(begin, 0, &arg[i]) != 0)
                        break;
        }