drm/amd/display: Fix mismatch type comparison in custom_float
authorSamson Tam <Samson.Tam@amd.com>
Tue, 7 Jan 2025 19:16:04 +0000 (14:16 -0500)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 25 Feb 2025 16:44:01 +0000 (11:44 -0500)
[Why & How]
Passing uint into uchar function param.  Pass uint instead

Signed-off-by: Samson Tam <Samson.Tam@amd.com>
Reviewed-by: Alvin Lee <alvin.lee2@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/sspl/spl_fixpt31_32.c
drivers/gpu/drm/amd/display/dc/sspl/spl_fixpt31_32.h

index 131f1e3949d33fd639a302be63642a7ac1df5092..52d97918a3bd2140c8fe0200a04bc9e28bceb861 100644 (file)
@@ -346,7 +346,7 @@ struct spl_fixed31_32 spl_fixpt_exp(struct spl_fixed31_32 arg)
                if (m > 0)
                        return spl_fixpt_shl(
                                spl_fixed31_32_exp_from_taylor_series(r),
-                               (unsigned char)m);
+                               (unsigned int)m);
                else
                        return spl_fixpt_div_int(
                                spl_fixed31_32_exp_from_taylor_series(r),
index ed2647f9a099970cca1f480ce70e34de492af71a..9f349ffe91485b9c029bcc71f51e53ec65afcb84 100644 (file)
@@ -189,7 +189,7 @@ static inline struct spl_fixed31_32 spl_fixpt_clamp(
  * @brief
  * result = arg << shift
  */
-static inline struct spl_fixed31_32 spl_fixpt_shl(struct spl_fixed31_32 arg, unsigned char shift)
+static inline struct spl_fixed31_32 spl_fixpt_shl(struct spl_fixed31_32 arg, unsigned int shift)
 {
        SPL_ASSERT(((arg.value >= 0) && (arg.value <= LLONG_MAX >> shift)) ||
                ((arg.value < 0) && (arg.value >= ~(LLONG_MAX >> shift))));
@@ -203,7 +203,7 @@ static inline struct spl_fixed31_32 spl_fixpt_shl(struct spl_fixed31_32 arg, uns
  * @brief
  * result = arg >> shift
  */
-static inline struct spl_fixed31_32 spl_fixpt_shr(struct spl_fixed31_32 arg, unsigned char shift)
+static inline struct spl_fixed31_32 spl_fixpt_shr(struct spl_fixed31_32 arg, unsigned int shift)
 {
        bool negative = arg.value < 0;