mlxsw: core_linecards: Fix size of array element during ini_files allocation
authorJiri Pirko <jiri@nvidia.com>
Wed, 20 Apr 2022 14:20:07 +0000 (17:20 +0300)
committerJakub Kicinski <kuba@kernel.org>
Fri, 22 Apr 2022 22:40:23 +0000 (15:40 -0700)
types_info->ini_files is an array of pointers
to struct mlxsw_linecard_ini_file.

Fix the kmalloc_array() argument to be of a size of a pointer.

Addresses-Coverity: ("Incorrect expression  (SIZEOF_MISMATCH)")
Fixes: b217127e5e4e ("mlxsw: core_linecards: Add line card objects and implement provisioning")
Signed-off-by: Jiri Pirko <jiri@nvidia.com>
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Link: https://lore.kernel.org/r/20220420142007.3041173-1-idosch@nvidia.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/mellanox/mlxsw/core_linecards.c

index 90e487cc2e2a52c6bab61e946b779a4e077fe972..5c9869dcf674a3ca1d1ee180d51827aeaffaec54 100644 (file)
@@ -1032,7 +1032,7 @@ static int mlxsw_linecard_types_init(struct mlxsw_core *mlxsw_core,
        }
 
        types_info->ini_files = kmalloc_array(types_info->count,
-                                             sizeof(struct mlxsw_linecard_ini_file),
+                                             sizeof(struct mlxsw_linecard_ini_file *),
                                              GFP_KERNEL);
        if (!types_info->ini_files) {
                err = -ENOMEM;