[media] atomisp: use logical AND, not bitwise
authorGuru Das Srinagesh <gurooodas@gmail.com>
Thu, 18 May 2017 13:50:11 +0000 (10:50 -0300)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Fri, 19 May 2017 09:56:37 +0000 (06:56 -0300)
Fixes sparse warning "dubious: x & !y" in logical expression.

Signed-off-by: Guru Das Srinagesh <gurooodas@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/binary/src/binary.c

index a8b93a756e4102ed0d3791a4538fb667987d95e5..ae0b229c9fb82e37194e5c6a4bb89a21d057f890 100644 (file)
@@ -1658,7 +1658,7 @@ ia_css_binary_find(struct ia_css_binary_descr *descr,
                        candidate->internal.max_height);
                        continue;
                }
-               if (!candidate->enable.ds && need_ds & !(xcandidate->num_output_pins > 1)) {
+               if (!candidate->enable.ds && need_ds && !(xcandidate->num_output_pins > 1)) {
                        ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE,
                                "ia_css_binary_find() [%d] continue: !%d && %d\n",
                                __LINE__, candidate->enable.ds, (int)need_ds);