watchdog: da9063_wdt: Use 'dev' instead of dereferencing it repeatedly
authorGuenter Roeck <linux@roeck-us.net>
Mon, 8 Apr 2019 19:38:36 +0000 (12:38 -0700)
committerWim Van Sebroeck <wim@linux-watchdog.org>
Sun, 5 May 2019 19:02:17 +0000 (21:02 +0200)
Introduce local variable 'struct device *dev' and use it instead of
dereferencing it repeatedly.

The conversion was done automatically with coccinelle using the
following semantic patches. The semantic patches and the scripts
used to generate this commit log are available at
https://github.com/groeck/coccinelle-patches

Cc: Support Opensource <support.opensource@diasemi.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Acked-by: Steve Twiss <stwiss.opensource@diasemi.com>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
drivers/watchdog/da9063_wdt.c

index 384dca16af8b36bf2e51f8ed6bfeb5ca82e30e06..06eb9070203c8cdd752db8786e3510db19881031 100644 (file)
@@ -188,17 +188,18 @@ static const struct watchdog_ops da9063_watchdog_ops = {
 
 static int da9063_wdt_probe(struct platform_device *pdev)
 {
+       struct device *dev = &pdev->dev;
        struct da9063 *da9063;
        struct watchdog_device *wdd;
 
-       if (!pdev->dev.parent)
+       if (!dev->parent)
                return -EINVAL;
 
-       da9063 = dev_get_drvdata(pdev->dev.parent);
+       da9063 = dev_get_drvdata(dev->parent);
        if (!da9063)
                return -EINVAL;
 
-       wdd = devm_kzalloc(&pdev->dev, sizeof(*wdd), GFP_KERNEL);
+       wdd = devm_kzalloc(dev, sizeof(*wdd), GFP_KERNEL);
        if (!wdd)
                return -ENOMEM;
 
@@ -208,7 +209,7 @@ static int da9063_wdt_probe(struct platform_device *pdev)
        wdd->max_timeout = DA9063_WDT_MAX_TIMEOUT;
        wdd->min_hw_heartbeat_ms = DA9063_RESET_PROTECTION_MS;
        wdd->timeout = DA9063_WDG_TIMEOUT;
-       wdd->parent = &pdev->dev;
+       wdd->parent = dev;
 
        wdd->status = WATCHDOG_NOWAYOUT_INIT_STATUS;
 
@@ -222,7 +223,7 @@ static int da9063_wdt_probe(struct platform_device *pdev)
                set_bit(WDOG_HW_RUNNING, &wdd->status);
        }
 
-       return devm_watchdog_register_device(&pdev->dev, wdd);
+       return devm_watchdog_register_device(dev, wdd);
 }
 
 static struct platform_driver da9063_wdt_driver = {