autofs4 - fix deal with autofs4_write races
authorIan Kent <raven@themaw.net>
Fri, 13 Jan 2012 12:41:46 +0000 (20:41 +0800)
committerLinus Torvalds <torvalds@linux-foundation.org>
Fri, 13 Jan 2012 16:30:49 +0000 (08:30 -0800)
I don't know how I missed this obvious mistake when I
reviewed Als' patches, sorry.

[ Quoting Al:

Grr...  Note to self: do git status *and* git stash show -p
before git push.  Nothing like "WTF? I'd fixed that braino"
feeling ;-/

  Al sent the same patch - it got broken in commit d668dc56631d:
  "autofs4: deal with autofs4_write/autofs4_write races". ]

Reported-and-tested-by: Dave Airlie <airlied@redhat.com>
Signed-off-by: Ian Kent <raven@themaw.net>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/autofs4/waitq.c

index 9ef5b2914407c40327db81a5688850a808210991..da8876d38a7b7e3a50101f02817cbbbc460cec20 100644 (file)
@@ -76,7 +76,7 @@ static int autofs4_write(struct autofs_sb_info *sbi,
                data += wr;
                bytes -= wr;
        }
-       mutex_lock(&sbi->pipe_mutex);
+       mutex_unlock(&sbi->pipe_mutex);
 
        set_fs(fs);