pinctrl: pxa2xx: use devm_kmemdup_array()
authorRaag Jadav <raag.jadav@intel.com>
Wed, 12 Feb 2025 06:25:10 +0000 (11:55 +0530)
committerAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Mon, 24 Feb 2025 10:08:52 +0000 (12:08 +0200)
Convert to use devm_kmemdup_array() which is more robust.

Signed-off-by: Raag Jadav <raag.jadav@intel.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
drivers/pinctrl/pxa/pinctrl-pxa2xx.c

index 9e34b92ff5f2ddf89d565b87e6926b0af07d70ac..9fd7a8fb2bc44fb2593fb43df6c57a99bb49a435 100644 (file)
@@ -281,9 +281,8 @@ static int pxa2xx_build_functions(struct pxa_pinctrl *pctl)
                for (df = pctl->ppins[i].functions; df->name; df++)
                        if (!pxa2xx_find_function(pctl, df->name, functions))
                                (functions + pctl->nfuncs++)->name = df->name;
-       pctl->functions = devm_kmemdup(pctl->dev, functions,
-                                      pctl->nfuncs * sizeof(*functions),
-                                      GFP_KERNEL);
+       pctl->functions = devm_kmemdup_array(pctl->dev, functions, pctl->nfuncs,
+                                            sizeof(*functions), GFP_KERNEL);
        if (!pctl->functions)
                return -ENOMEM;
 
@@ -314,7 +313,8 @@ static int pxa2xx_build_groups(struct pxa_pinctrl *pctl)
                                                pctl->ppins[j].pin.name;
                func = pctl->functions + i;
                func->ngroups = ngroups;
-               func->groups = devm_kmemdup(pctl->dev, gtmp, ngroups * sizeof(*gtmp), GFP_KERNEL);
+               func->groups = devm_kmemdup_array(pctl->dev, gtmp, ngroups,
+                                                 sizeof(*gtmp), GFP_KERNEL);
                if (!func->groups)
                        return -ENOMEM;
        }