net: ucc_geth: use devm for register_netdev
authorRosen Penev <rosenp@gmail.com>
Mon, 4 Nov 2024 21:01:26 +0000 (13:01 -0800)
committerJakub Kicinski <kuba@kernel.org>
Thu, 7 Nov 2024 01:54:47 +0000 (17:54 -0800)
Avoids having to unregister manually.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
Link: https://patch.msgid.link/20241104210127.307420-4-rosenp@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/freescale/ucc_geth.c

index bc48a9421402967f9ae7598cc88a865d60e713be..acadebb7dd34f559a9261e19cc79ecbe5fd63fc9 100644 (file)
@@ -3724,7 +3724,7 @@ static int ucc_geth_probe(struct platform_device* ofdev)
        /* Carrier starts down, phylib will bring it up */
        netif_carrier_off(dev);
 
-       err = register_netdev(dev);
+       err = devm_register_netdev(&ofdev->dev, dev);
        if (err) {
                if (netif_msg_probe(ugeth))
                        pr_err("%s: Cannot register net device, aborting\n",
@@ -3755,7 +3755,6 @@ static void ucc_geth_remove(struct platform_device* ofdev)
        struct ucc_geth_private *ugeth = netdev_priv(dev);
        struct device_node *np = ofdev->dev.of_node;
 
-       unregister_netdev(dev);
        ucc_geth_memclean(ugeth);
        if (of_phy_is_fixed_link(np))
                of_phy_deregister_fixed_link(np);