r8169: remove original workaround for RTL8125 broken rx issue
authorHeiner Kallweit <hkallweit1@gmail.com>
Wed, 9 Oct 2024 05:48:05 +0000 (07:48 +0200)
committerJakub Kicinski <kuba@kernel.org>
Fri, 11 Oct 2024 01:36:28 +0000 (18:36 -0700)
Now that we have b9c7ac4fe22c ("r8169: disable ALDPS per default for
RTL8125"), the first attempt to fix the issue shouldn't be needed
any longer. So let's effectively revert 621735f59064 ("r8169: fix
rare issue with broken rx after link-down on RTL8125") and see
whether anybody complains.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/382d8c88-cbce-400f-ad62-fda0181c7e38@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/realtek/r8169_main.c

index 6651054305d22fe0cce23b9fbff1826079b282e9..7287e841bbf172a62840b406809664757ff61535 100644 (file)
@@ -4776,11 +4776,7 @@ static void r8169_phylink_handler(struct net_device *ndev)
        if (netif_carrier_ok(ndev)) {
                rtl_link_chg_patch(tp);
                pm_request_resume(d);
-               netif_wake_queue(tp->dev);
        } else {
-               /* In few cases rx is broken after link-down otherwise */
-               if (rtl_is_8125(tp))
-                       rtl_schedule_task(tp, RTL_FLAG_TASK_RESET_NO_QUEUE_WAKE);
                pm_runtime_idle(d);
        }