spi: pl022: don't use uninitialized variable
authorRabin Vincent <rabinv@axis.com>
Thu, 6 Apr 2017 08:16:23 +0000 (10:16 +0200)
committerMark Brown <broonie@kernel.org>
Thu, 6 Apr 2017 10:55:22 +0000 (11:55 +0100)
The num-cs property is a required property according to the binding
documentation.  However, if it is not present, the driver currently
simply uses random junk from the stack for the num-cs since the variable
whose pointer is passed to of_property_read_u32() is not initialized.

Signed-off-by: Rabin Vincent <rabinv@axis.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-pl022.c

index f7f7ba17b40e97597ae76d2f7e58fae3844ec6ef..2f76e022cc590093518d3c6785830e218d92b9cc 100644 (file)
@@ -2074,7 +2074,7 @@ pl022_platform_data_dt_get(struct device *dev)
 {
        struct device_node *np = dev->of_node;
        struct pl022_ssp_controller *pd;
-       u32 tmp;
+       u32 tmp = 0;
 
        if (!np) {
                dev_err(dev, "no dt node defined\n");