HID: nintendo: Set phys property of input device based on HID phys
authorThomas Schneider <qsx@chaotikum.eu>
Sat, 11 Jun 2022 01:03:59 +0000 (03:03 +0200)
committerJiri Kosina <jkosina@suse.cz>
Wed, 15 Jun 2022 14:42:32 +0000 (16:42 +0200)
While the MAC address the uniq identifier is set to (cf. commit
1425247383c5 ("HID: nintendo: set controller uniq to MAC")) is certainly
unique, the physical location can be more helpful in user interfaces.  The
underlying hid_device already provides a suitable value, so we can simply
reuse this here.

Signed-off-by: Thomas Schneider <qsx@chaotikum.eu>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/hid-nintendo.c

index 2204de889739f526be3fa7fa585f3b11b11b8b06..df9cd5d883c0ceb97e1a93ae4f7cb0cc151a381d 100644 (file)
@@ -1634,6 +1634,7 @@ static int joycon_input_create(struct joycon_ctlr *ctlr)
        ctlr->input->id.version = hdev->version;
        ctlr->input->uniq = ctlr->mac_addr_str;
        ctlr->input->name = name;
+       ctlr->input->phys = hdev->phys;
        input_set_drvdata(ctlr->input, ctlr);
 
        /* set up sticks and buttons */
@@ -1713,6 +1714,7 @@ static int joycon_input_create(struct joycon_ctlr *ctlr)
        ctlr->imu_input->id.version = hdev->version;
        ctlr->imu_input->uniq = ctlr->mac_addr_str;
        ctlr->imu_input->name = imu_name;
+       ctlr->imu_input->phys = hdev->phys;
        input_set_drvdata(ctlr->imu_input, ctlr);
 
        /* configure imu axes */