spi: stm32-ospi: clean up on error in probe()
authorDan Carpenter <dan.carpenter@linaro.org>
Wed, 11 Jun 2025 13:09:45 +0000 (16:09 +0300)
committerMark Brown <broonie@kernel.org>
Wed, 11 Jun 2025 15:47:53 +0000 (16:47 +0100)
If reset_control_acquire() fails, then we can't return directly.
We need to do a little clean up first.

Fixes: cf2c3eceb757 ("spi: stm32-ospi: Make usage of reset_control_acquire/release() API")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://patch.msgid.link/aEmAGTUzzKZlLe3K@stanley.mountain
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-stm32-ospi.c

index db6b1cfc970f6c80515a39073e2389311796da8f..4ab7e86f4bd51638b79c8f8716e458f98b447f25 100644 (file)
@@ -937,8 +937,10 @@ static int stm32_ospi_probe(struct platform_device *pdev)
                goto err_pm_enable;
 
        ret = reset_control_acquire(ospi->rstc);
-       if (ret)
-               return dev_err_probe(dev, ret, "Can not acquire reset %d\n", ret);
+       if (ret) {
+               dev_err_probe(dev, ret, "Can not acquire reset %d\n", ret);
+               goto err_pm_resume;
+       }
 
        reset_control_assert(ospi->rstc);
        udelay(2);