serial: 8250_bcm2835aux: Restore clock error handling
authorStefan Wahren <wahrenst@gmx.net>
Wed, 20 Dec 2023 11:43:34 +0000 (12:43 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 4 Jan 2024 15:23:03 +0000 (16:23 +0100)
The commit fcc446c8aa63 ("serial: 8250_bcm2835aux: Add ACPI support")
dropped the error handling for clock acquiring. But even an optional
clock needs this.

Fixes: fcc446c8aa63 ("serial: 8250_bcm2835aux: Add ACPI support")
Cc: stable <stable@kernel.org>
Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Link: https://lore.kernel.org/r/20231220114334.4712-1-wahrenst@gmx.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/8250/8250_bcm2835aux.c

index b5760f914a8cf79e14c8db41557819417ce916ee..beac6b340acef7cac394456e10b6244be7568deb 100644 (file)
@@ -119,6 +119,8 @@ static int bcm2835aux_serial_probe(struct platform_device *pdev)
 
        /* get the clock - this also enables the HW */
        data->clk = devm_clk_get_optional(&pdev->dev, NULL);
+       if (IS_ERR(data->clk))
+               return dev_err_probe(&pdev->dev, PTR_ERR(data->clk), "could not get clk\n");
 
        /* get the interrupt */
        ret = platform_get_irq(pdev, 0);