net: bridge: Exit if multicast_init_stats fails
authorBreno Leitao <leitao@debian.org>
Tue, 27 Feb 2024 18:23:37 +0000 (10:23 -0800)
committerJakub Kicinski <kuba@kernel.org>
Thu, 29 Feb 2024 04:15:32 +0000 (20:15 -0800)
If br_multicast_init_stats() fails, there is no need to set lockdep
classes. Just return from the error path.

Signed-off-by: Breno Leitao <leitao@debian.org>
Acked-by: Nikolay Aleksandrov <razor@blackwall.org>
Link: https://lore.kernel.org/r/20240227182338.2739884-2-leitao@debian.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/bridge/br_device.c

index 4f636f7b0555813feeb1e46a6cc569580b43c3cb..c366ccc8b3db7b3052faea7fc75367d6a9f052b5 100644 (file)
@@ -135,10 +135,11 @@ static int br_dev_init(struct net_device *dev)
                br_vlan_flush(br);
                br_mdb_hash_fini(br);
                br_fdb_hash_fini(br);
+               return err;
        }
 
        netdev_lockdep_set_classes(dev);
-       return err;
+       return 0;
 }
 
 static void br_dev_uninit(struct net_device *dev)