dmaengine: st_fdma: Annotate struct st_fdma_desc with __counted_by
authorKees Cook <keescook@chromium.org>
Thu, 17 Aug 2023 23:58:48 +0000 (16:58 -0700)
committerVinod Koul <vkoul@kernel.org>
Thu, 28 Sep 2023 11:12:14 +0000 (16:42 +0530)
Prepare for the coming implementation by GCC and Clang of the __counted_by
attribute. Flexible array members annotated with __counted_by can have
their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
(for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
functions).

As found with Coccinelle[1], add __counted_by for struct st_fdma_desc.

[1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci

Cc: Vinod Koul <vkoul@kernel.org>
Cc: Patrice Chotard <patrice.chotard@foss.st.com>
Cc: linux-arm-kernel@lists.infradead.org
Cc: dmaengine@vger.kernel.org
Signed-off-by: Kees Cook <keescook@chromium.org>
Reviewed-by: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Link: https://lore.kernel.org/r/20230817235859.49846-11-keescook@chromium.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/st_fdma.h

index fa15b97a3bab665f97ab7df7a3cd7b0eee1cbd3f..f296412e96b6a5c5e2749077bb5e8f3725afe369 100644 (file)
@@ -97,7 +97,7 @@ struct st_fdma_desc {
        struct st_fdma_chan *fchan;
        bool iscyclic;
        unsigned int n_nodes;
-       struct st_fdma_sw_node node[];
+       struct st_fdma_sw_node node[] __counted_by(n_nodes);
 };
 
 enum st_fdma_type {