projects
/
linux-block.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
857282b
)
net: rfkill: gpio: Add check for clk_enable()
author
Mingwei Zheng
<zmw12306@gmail.com>
Fri, 8 Nov 2024 19:53:41 +0000
(14:53 -0500)
committer
Johannes Berg
<johannes.berg@intel.com>
Tue, 12 Nov 2024 12:30:31 +0000
(13:30 +0100)
Add check for the return value of clk_enable() to catch the potential
error.
Fixes:
7176ba23f8b5
("net: rfkill: add generic gpio rfkill driver")
Signed-off-by: Mingwei Zheng <zmw12306@gmail.com>
Signed-off-by: Jiasheng Jiang <jiashengjiangcool@gmail.com>
Link:
https://patch.msgid.link/20241108195341.1853080-1-zmw12306@gmail.com
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
net/rfkill/rfkill-gpio.c
patch
|
blob
|
blame
|
history
diff --git
a/net/rfkill/rfkill-gpio.c
b/net/rfkill/rfkill-gpio.c
index c268c2b011f4281e539ec5b972657d5f99383d7e..a8e21060112ffdd162676aaa483d4ede71a1efda 100644
(file)
--- a/
net/rfkill/rfkill-gpio.c
+++ b/
net/rfkill/rfkill-gpio.c
@@
-32,8
+32,12
@@
static int rfkill_gpio_set_power(void *data, bool blocked)
{
struct rfkill_gpio_data *rfkill = data;
- if (!blocked && !IS_ERR(rfkill->clk) && !rfkill->clk_enabled)
- clk_enable(rfkill->clk);
+ if (!blocked && !IS_ERR(rfkill->clk) && !rfkill->clk_enabled) {
+ int ret = clk_enable(rfkill->clk);
+
+ if (ret)
+ return ret;
+ }
gpiod_set_value_cansleep(rfkill->shutdown_gpio, !blocked);
gpiod_set_value_cansleep(rfkill->reset_gpio, !blocked);