drm/amd/display: Remove incorrect checking in dmub aux handler
authorWayne Lin <Wayne.Lin@amd.com>
Sun, 20 Apr 2025 08:56:54 +0000 (16:56 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Mon, 5 May 2025 17:01:50 +0000 (13:01 -0400)
[Why & How]
"Request length != reply length" is expected behavior defined in spec.
It's not an invalid reply. Besides, replied data handling logic is not
designed to be written in amdgpu_dm_process_dmub_aux_transfer_sync().
Remove the incorrectly handling section.

Fixes: ead08b95fa50 ("drm/amd/display: Fix race condition in DPIA AUX transfer")
Cc: Mario Limonciello <mario.limonciello@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Reviewed-by: Ray Wu <ray.wu@amd.com>
Signed-off-by: Wayne Lin <Wayne.Lin@amd.com>
Signed-off-by: Ray Wu <ray.wu@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

index 2c4cae5e1a20374cdd4063933d952dcae2eadc2b..7e41f99e9e265f10ef3b49fda0209f6bc91e9347 100644 (file)
@@ -12854,19 +12854,9 @@ int amdgpu_dm_process_dmub_aux_transfer_sync(
                payload->reply[0] = (adev->dm.dmub_notify->aux_reply.command >> 4) & 0xF;
 
        if (!payload->write && p_notify->aux_reply.length &&
-                       (payload->reply[0] == AUX_TRANSACTION_REPLY_AUX_ACK)) {
-
-               if (payload->length != p_notify->aux_reply.length) {
-                       drm_warn(adev_to_drm(adev), "invalid read length %d from DPIA AUX 0x%x(%d)!\n",
-                               p_notify->aux_reply.length,
-                                       payload->address, payload->length);
-                       *operation_result = AUX_RET_ERROR_INVALID_REPLY;
-                       goto out;
-               }
-
+                       (payload->reply[0] == AUX_TRANSACTION_REPLY_AUX_ACK))
                memcpy(payload->data, p_notify->aux_reply.data,
                                p_notify->aux_reply.length);
-       }
 
        /* success */
        ret = p_notify->aux_reply.length;