ASoC: rt712-sdca: remove redundant else path of if statement
authorColin Ian King <colin.i.king@gmail.com>
Wed, 7 May 2025 14:09:07 +0000 (15:09 +0100)
committerMark Brown <broonie@kernel.org>
Thu, 8 May 2025 01:32:52 +0000 (10:32 +0900)
There is an if/else check where the else part is executed if
adc_vol_flag is true, this else path checks if adc_vol_flag
is true (which is a redundant second check) and the if path is
always taken. Remove the redundant check and remove the else
path since that can never occur.

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Link: https://patch.msgid.link/20250507140907.255562-1-colin.i.king@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/rt712-sdca.c

index 19d99b9d4ab26e8e940bfe9ed6a0ff65b715dd88..570c2af1245d64d092fd05d2febb8307fe750de8 100644 (file)
@@ -1065,12 +1065,8 @@ static int rt712_sdca_dmic_set_gain_get(struct snd_kcontrol *kcontrol,
 
                if (!adc_vol_flag) /* boost gain */
                        ctl = regvalue / 0x0a00;
-               else { /* ADC gain */
-                       if (adc_vol_flag)
-                               ctl = p->max - (((0x1e00 - regvalue) & 0xffff) / interval_offset);
-                       else
-                               ctl = p->max - (((0 - regvalue) & 0xffff) / interval_offset);
-               }
+               else /* ADC gain */
+                       ctl = p->max - (((0x1e00 - regvalue) & 0xffff) / interval_offset);
 
                ucontrol->value.integer.value[i] = ctl;
        }