spi: Do not check for 0 return after calling platform_get_irq()

It is not possible for platform_get_irq() to return 0. Use the
return value from platform_get_irq().

Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com> #
Link: https://lore.kernel.org/r/20230802093238.975906-1-ruanjinjie@huawei.com
Signed-off-by: Mark Brown <broonie@kernel.org>

diff --git a/drivers/spi/spi-axi-spi-engine.c b/drivers/spi/spi-axi-spi-engine.c
index 89661f3b0d44c69f8fe5b862501c3a2ed44d6bf5..c3224b85bc79ed44cf3ddfffc1a41300dbff065d 100644 (file)
--- a/drivers/spi/spi-axi-spi-engine.c
+++ b/drivers/spi/spi-axi-spi-engine.c
@@ -470,8 +470,8 @@ static int spi_engine_probe(struct platform_device *pdev)
        int ret;
 
        irq = platform_get_irq(pdev, 0);
-       if (irq <= 0)
-               return -ENXIO;
+       if (irq < 0)
+               return irq;
 
        spi_engine = devm_kzalloc(&pdev->dev, sizeof(*spi_engine), GFP_KERNEL);
        if (!spi_engine)

diff --git a/drivers/spi/spi-bcm2835.c b/drivers/spi/spi-bcm2835.c
index c16abc2a9e9bdc43dc3e9db9baa8a92e2b47762d..3f7f61ba66d54d6cd2b4ab67d698d08ff4ef71d0 100644 (file)
--- a/drivers/spi/spi-bcm2835.c
+++ b/drivers/spi/spi-bcm2835.c
@@ -1360,8 +1360,8 @@ static int bcm2835_spi_probe(struct platform_device *pdev)
        ctlr->max_speed_hz = clk_get_rate(bs->clk) / 2;
 
        bs->irq = platform_get_irq(pdev, 0);
-       if (bs->irq <= 0)
-               return bs->irq ? bs->irq : -ENODEV;
+       if (bs->irq < 0)
+               return bs->irq;
 
        err = clk_prepare_enable(bs->clk);
        if (err)

diff --git a/drivers/spi/spi-bcm2835aux.c b/drivers/spi/spi-bcm2835aux.c
index 8ace417c0a29b8fa74725d25170a97d478d36fe0..843dac84758485738f781012b7c45fc62a6c24c7 100644 (file)
--- a/drivers/spi/spi-bcm2835aux.c
+++ b/drivers/spi/spi-bcm2835aux.c
@@ -520,8 +520,8 @@ static int bcm2835aux_spi_probe(struct platform_device *pdev)
        }
 
        bs->irq = platform_get_irq(pdev, 0);
-       if (bs->irq <= 0)
-               return bs->irq ? bs->irq : -ENODEV;
+       if (bs->irq < 0)
+               return bs->irq;
 
        /* this also enables the HW block */
        err = clk_prepare_enable(bs->clk);

diff --git a/drivers/spi/spi-cadence.c b/drivers/spi/spi-cadence.c
index 42f101d357c3056c2015a1bbded7237b5bd71b9e..7b0136536cfb7d300e9aba2538c77f4621dee0f5 100644 (file)
--- a/drivers/spi/spi-cadence.c
+++ b/drivers/spi/spi-cadence.c
@@ -627,8 +627,8 @@ static int cdns_spi_probe(struct platform_device *pdev)
        cdns_spi_init_hw(xspi, spi_controller_is_slave(ctlr));
 
        irq = platform_get_irq(pdev, 0);
-       if (irq <= 0) {
-               ret = -ENXIO;
+       if (irq < 0) {
+               ret = irq;
                goto clk_dis_all;
        }