macvlan: Change status when lower device goes down
authorTravis Brown <travisb@arista.com>
Tue, 10 Jul 2018 00:35:01 +0000 (00:35 +0000)
committerDavid S. Miller <davem@davemloft.net>
Thu, 12 Jul 2018 06:07:22 +0000 (23:07 -0700)
Today macvlan ignores the notification when a lower device goes
administratively down, preventing the lack of connectivity from
bubbling up.

Processing NETDEV_DOWN results in a macvlan state of LOWERLAYERDOWN
with NO-CARRIER which should be easy to interpret in userspace.

2: lower: <BROADCAST,MULTICAST> mtu 1500 qdisc mq state DOWN mode DEFAULT group default qlen 1000
3: macvlan@lower: <NO-CARRIER,BROADCAST,MULTICAST,UP,M-DOWN> mtu 1500 qdisc noqueue state LOWERLAYERDOWN mode DEFAULT group default qlen 1000

Signed-off-by: Suresh Krishnan <skrishnan@arista.com>
Signed-off-by: Travis Brown <travisb@arista.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/macvlan.c

index 401e1d1ce1ec421676a7c603cc922ba2083d92d6..cfda146f3b3bbb799532a48e2705c2fd4b5f2661 100644 (file)
@@ -1641,6 +1641,7 @@ static int macvlan_device_event(struct notifier_block *unused,
 
        switch (event) {
        case NETDEV_UP:
+       case NETDEV_DOWN:
        case NETDEV_CHANGE:
                list_for_each_entry(vlan, &port->vlans, list)
                        netif_stacked_transfer_operstate(vlan->lowerdev,