crypto: cavium/nitrox - fix warnings while printing atomic64_t types
authorSrikanth Jampala <Jampala.Srikanth@cavium.com>
Sat, 29 Sep 2018 08:19:07 +0000 (13:49 +0530)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 5 Oct 2018 02:22:48 +0000 (10:22 +0800)
fix compilation warnings with nitrox_debugfs.c while printing
atomic64_t types on arm64. typecast the atomic64_read() value to u64

This issue is reported by Ard Biesheuvel

drivers/crypto/cavium/nitrox/nitrox_debugfs.c:62:30:
warning: format ‘%lld’ expects argument of type ‘long long int’,
         but argument 3 has type ‘long int’ [-Wformat=]
  seq_printf(s, "  Posted: %lld\n", atomic64_read(&ndev->stats.posted));
                              ^
Fixes: 2a8780be9c26 (crypto: cavium/nitrox - updated debugfs information)
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reported-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Signed-off-by: Srikanth Jampala <Jampala.Srikanth@cavium.com>
Reviewed-by: Gadam Sreerama <sgadam@cavium.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/cavium/nitrox/nitrox_debugfs.c

index 2f1e74ea846ef0d0ba8c0f867e280185c9561821..5f3cd5fafe048b9f204ccf821db87c7ffffd4a9e 100644 (file)
@@ -59,10 +59,12 @@ static int stats_show(struct seq_file *s, void *v)
        struct nitrox_device *ndev = s->private;
 
        seq_printf(s, "NITROX [%d] Request Statistics\n", ndev->idx);
-       seq_printf(s, "  Posted: %lld\n", atomic64_read(&ndev->stats.posted));
-       seq_printf(s, "  Completed: %lld\n",
-                  atomic64_read(&ndev->stats.completed));
-       seq_printf(s, "  Dropped: %lld\n", atomic64_read(&ndev->stats.dropped));
+       seq_printf(s, "  Posted: %llu\n",
+                  (u64)atomic64_read(&ndev->stats.posted));
+       seq_printf(s, "  Completed: %llu\n",
+                  (u64)atomic64_read(&ndev->stats.completed));
+       seq_printf(s, "  Dropped: %llu\n",
+                  (u64)atomic64_read(&ndev->stats.dropped));
 
        return 0;
 }