projects
/
linux-block.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
5471e97
)
ALSA: hda: Add missing rwsem around snd_ctl_remove() calls
author
Takashi Iwai
<tiwai@suse.de>
Tue, 16 Nov 2021 07:13:14 +0000
(08:13 +0100)
committer
Takashi Iwai
<tiwai@suse.de>
Tue, 16 Nov 2021 07:13:56 +0000
(08:13 +0100)
snd_ctl_remove() has to be called with card->controls_rwsem held (when
called after the card instantiation). This patch add the missing
rwsem calls around it.
Fixes:
d13bd412dce2
("ALSA: hda - Manage kcontrol lists")
Link:
https://lore.kernel.org/r/20211116071314.15065-3-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/hda_codec.c
patch
|
blob
|
blame
|
history
diff --git
a/sound/pci/hda/hda_codec.c
b/sound/pci/hda/hda_codec.c
index 0c4a337c9fc0d266db5afd4d37210a33c889e61e..eda70814369bd628676833352f3de2c3c1c3472e 100644
(file)
--- a/
sound/pci/hda/hda_codec.c
+++ b/
sound/pci/hda/hda_codec.c
@@
-1727,8
+1727,11
@@
void snd_hda_ctls_clear(struct hda_codec *codec)
{
int i;
struct hda_nid_item *items = codec->mixers.list;
+
+ down_write(&codec->card->controls_rwsem);
for (i = 0; i < codec->mixers.used; i++)
snd_ctl_remove(codec->card, items[i].kctl);
+ up_write(&codec->card->controls_rwsem);
snd_array_free(&codec->mixers);
snd_array_free(&codec->nids);
}