drm/i915: Fix documentation for intel_dpll_get_freq()
authorImre Deak <imre.deak@intel.com>
Wed, 4 Mar 2020 15:09:18 +0000 (17:09 +0200)
committerImre Deak <imre.deak@intel.com>
Mon, 9 Mar 2020 10:37:23 +0000 (12:37 +0200)
Fix the following kerneldoc warning and while at it also the doc for the
corresponding vfunc hook.

$ make htmldocs 2>&1 > /dev/null | grep i915
./drivers/gpu/drm/i915/display/intel_dpll_mgr.h:285: warning: Function parameter or member 'get_freq' not described in 'intel_shared_dpll_funcs'

Signed-off-by: Imre Deak <imre.deak@intel.com>
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200304150918.25473-1-imre.deak@intel.com
drivers/gpu/drm/i915/display/intel_dpll_mgr.c
drivers/gpu/drm/i915/display/intel_dpll_mgr.h

index 76d14486b3a5985aa4d0e00d1b21e51d68d80ac8..2d47f1f756a2ec294c2c939b20305d255931f6a3 100644 (file)
@@ -4408,6 +4408,13 @@ void intel_update_active_dpll(struct intel_atomic_state *state,
        dpll_mgr->update_active_dpll(state, crtc, encoder);
 }
 
+/**
+ * intel_dpll_get_freq - calculate the DPLL's output frequency
+ * @i915: i915 device
+ * @pll: DPLL for which to calculate the output frequency
+ *
+ * Return the output frequency corresponding to @pll's current state.
+ */
 int intel_dpll_get_freq(struct drm_i915_private *i915,
                        const struct intel_shared_dpll *pll)
 {
index 5c847627580ab838f9e21540d8bf4771a53882de..5d9a2bc371e7cdcec0f1608856382e819264b54d 100644 (file)
@@ -279,6 +279,12 @@ struct intel_shared_dpll_funcs {
                             struct intel_shared_dpll *pll,
                             struct intel_dpll_hw_state *hw_state);
 
+       /**
+        * @get_freq:
+        *
+        * Hook for calculating the pll's output frequency based on its
+        * current state.
+        */
        int (*get_freq)(struct drm_i915_private *i915,
                        const struct intel_shared_dpll *pll);
 };